[
https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595822#comment-15595822
]
Maryann Xue commented on PHOENIX-3355:
--------------------------------------
Thank you for the patch, [~lomoree]! Yes, you are going in the right direction.
A few things, though:
1. I see that you moved "registerBuiltins()" (make it
"registerBuiltInFunctions()"?) from PhoenixSchema's constructor to
"getFunctions()". Is there any reason why you did that?
2. There is a BUILT_IN_FUNCTION_MAP in ParseNodeFactory. Probably you should
use that instead of going through the Expression sub-classes. And that way you
don't need to create new instances of BuiltInFunctionInfo any more. And not
sure if "createFromBuiltIn()" should live in "PFunction", maybe we can move it
out to PhoenixSchema or somewhere else?
3. Once all built-in functions are registered in PhoenixSchema, we can remove
those existing function translation in CalciteUtils since they will all go
through the UDF translation.
> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
> Key: PHOENIX-3355
> URL: https://issues.apache.org/jira/browse/PHOENIX-3355
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Eric Lomore
> Labels: calcite
> Attachments: PHOENIX-3355.wip
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
