[
https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15635328#comment-15635328
]
James Taylor commented on PHOENIX-3355:
---------------------------------------
Patch looks good, [~maryannxue], but can you get rid of the nodeClass
annotation everywhere as your new mechanism replaces that:
{code}
@BuiltInFunction(name=ToTimestampFunction.NAME,
nodeClass=ToTimestampParseNode.class,
{code}
Also, by getting rid of that annotation, you'll see all the places where you
need to update to the new mechanism.
> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
> Key: PHOENIX-3355
> URL: https://issues.apache.org/jira/browse/PHOENIX-3355
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Eric Lomore
> Labels: calcite
> Attachments: PHOENIX-3355.function_constructor.patch,
> PHOENIX-3355.wip, PHOENIX-3355.wip2
>
>
> We should register all Phoenix built-in functions that don't exist in Calcite.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
