[ 
https://issues.apache.org/jira/browse/PHOENIX-3462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646819#comment-15646819
 ] 

Samarth Jain commented on PHOENIX-3462:
---------------------------------------

I am not sure there is much we can do here, [~jamestaylor]. Majority of tests 
are testing with isNamespaceMapped set to true or false. And we need to enable 
name space mapping via client and server side configs which means we need to 
extend BaseOwnClusterIT.

> BaseLocalIndexIT is changing server side properties of the shared test cluster
> ------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3462
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3462
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3462.patch
>
>
> {code}
> @BeforeClass
>     public static void doSetup() throws Exception {
>         Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(7);
>         serverProps.put(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, "true");
>         Map<String, String> clientProps = Maps.newHashMapWithExpectedSize(1);
>         clientProps.put(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, "true");
>         setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()), 
> new ReadOnlyProps(clientProps.entrySet().iterator()));
>     }
> {code}
> FYI, [~rajeshbabu]. If any test class needs to change the server side 
> properties, then it needs to extend NeedsOwnClusterIT class. Tests extending 
> ParallelStatsDisabledIT all share the same minicluster. So if a test like 
> LocalIndexIT runs first, then subsequent tests could fail because they will 
> unexpectedly see name space mapping as enabled on the server side.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to