[ 
https://issues.apache.org/jira/browse/PHOENIX-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684913#comment-15684913
 ] 

Maryann Xue commented on PHOENIX-3488:
--------------------------------------

The problem was caused by AggregateExpandDistinctAggregatesRule, which kept 
being filed endlessly. Simply adding 
{{planner.removeRule(AggregateExpandDistinctAggregatesRule.INSTANCE);}} will 
get rid of this problem. I believe this is a Calcite bug and we don't need this 
rule once we implement all XXX(distinct x) calls. Anyway, Phoenix only supports 
COUNT(DISTINCT x) right now, so you might still need to keep some of the 
not-supported-feature check there, both in 
{{PhoenixConverterRules.isConvertible()}} and in 
{{PhoenixAbstractAggregate.serializeAggregators()}}. I suggest removing all 
checks from PhoenixAbstractAggregate constructor though, which is to keep 
things in just one place and follow the current convention of all other Phoenix 
rels.

> Support COUNT(DISTINCT x) in Phoenix-Calcite Integration
> --------------------------------------------------------
>
>                 Key: PHOENIX-3488
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3488
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eric Lomore
>            Assignee: Eric Lomore
>              Labels: calcite
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to