+1 On Mon, Nov 21, 2016 at 4:38 PM, Samarth Jain <[email protected]> wrote:
> +1 > > On Mon, Nov 21, 2016 at 3:43 PM Mujtaba Chohan <[email protected]> wrote: > > > +1. > > > > Verified it's backward compatible and performance is on par with Phoenix > > 4.8.0-HBase0.98. > > > > On Mon, Nov 21, 2016 at 3:16 PM, Thomas D'Silva <[email protected]> > > wrote: > > > > > +1 > > > > > > Ran integration tests. > > > Manually tested indexes and transactions. > > > > > > On Mon, Nov 21, 2016 at 1:49 PM, Josh Elser <[email protected]> wrote: > > > > > > > +1 (binding) > > > > > > > > * xsums/sigs pass > > > > * KEYS is present > > > > * Verified no change in pom.xml (for dependencies which might affect > > L&N) > > > > > > > > For each src-release: > > > > * Top level LICENSE/NOTICE files look OK > > > > * No unexpected binary files or files missing ASL header in src > release > > > > (`mvn apache-rat:check`) > > > > * Can build from src and run tests (`mvn package`) > > > > > > > > The only thing I have to add is that the 0.98 src tests still hang > > > > indefinitely when using jdk8. This is expected IIRC, but it would be > > nice > > > > to make sure this gets mentioned in the release notes we ship with > the > > > > release since 1.1 and 1.2 are jdk8 compatible. > > > > > > > > - Josh > > > > > > > > James Taylor wrote: > > > > > > > >> Hello Everyone, > > > >> > > > >> This is a call for a vote on Apache Phoenix 4.9.0 RC5. This is the > > next > > > >> minor release of Phoenix 4, compatible with Apache HBase 0.98, 1.1& > > > 1.2. > > > >> > > > >> The release includes both a source-only release and a convenience > > binary > > > >> release for each supported HBase version. The previous RC was sunk > due > > > to > > > >> PHOENIX-3461 which has now been fixed. > > > >> > > > >> This release has feature parity with supported HBase versions and > > > includes > > > >> the following improvements: > > > >> - Atomic UPSERT through new ON DUPLICATE KEY syntax [1] > > > >> - Support for DEFAULT declaration in DDL statements [2] > > > >> - Specify guidepost width per table [3] > > > >> - Over 40 bugs fixed > > > >> > > > >> The source tarball, including signatures, digests, etc can be found > > at: > > > >> https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni > > > >> x-4.9.0-HBase-0.98-rc5/src/ > > > >> https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni > > > >> x-4.9.0-HBase-1.1-rc5/src/ > > > >> https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni > > > >> x-4.9.0-HBase-1.2-rc5/src/ > > > >> > > > >> The binary artifacts can be found at: > > > >> https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni > > > >> x-4.9.0-HBase-0.98-rc5/bin/ > > > >> https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni > > > >> x-4.9.0-HBase-1.1-rc5/bin/ > > > >> https://dist.apache.org/repos/dist/dev/phoenix/apache-phoeni > > > >> x-4.9.0-HBase-1.2-rc5/bin/ > > > >> > > > >> For a complete list of changes, see: > > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > > > >> ctId=12315120&version=12335845 > > > >> > > > >> Release artifacts are signed with the following key: > > > >> https://people.apache.org/keys/committer/mujtaba.asc > > > >> https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > >> > > > >> The hash and tag to be voted upon: > > > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm > > > >> it;h=30bb79b7abce29f415494214fc980208ff20e25f > > > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > >> h=refs/tags/v4.9.0-HBase-0.98-rc5 > > > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm > > > >> it;h=4d2602ae5f112105034fa071ce1a7cfb8b113389 > > > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > >> h=refs/tags/v4.9.0-HBase-1.1-rc5 > > > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=comm > > > >> it;h=279eb170761dbe081a0ffe93205f3a9294f4e3ea > > > >> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag; > > > >> h=refs/tags/v4.9.0-HBase-1.2-rc5 > > > >> > > > >> Vote will be open for at least 72 hours. Please vote: > > > >> > > > >> [ ] +1 approve > > > >> [ ] +0 no opinion > > > >> [ ] -1 disapprove (and reason why) > > > >> > > > >> Thanks, > > > >> The Apache Phoenix Team > > > >> > > > >> > > > >> [1] https://issues.apache.org/jira/browse/PHOENIX-6 > > > >> [2] https://issues.apache.org/jira/browse/PHOENIX-476 > > > >> [3] https://issues.apache.org/jira/browse/PHOENIX-2675 > > > >> > > > >> > > > > > >
