[
https://issues.apache.org/jira/browse/PHOENIX-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691104#comment-15691104
]
Hadoop QA commented on PHOENIX-3504:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12839910/PHOENIX-3504-1.patch
against master branch at commit e19c1734ea5aa0c0ee0e887c283a4712eb2dc803.
ATTACHMENT ID: 12839910
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
44 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if (columnInfo.getPrecision == null) DecimalType(38, 18) else
DecimalType(columnInfo.getPrecision, columnInfo.getScale)
+ if (columnInfo.getPrecision == null) DecimalType(38, 18) else
DecimalType(columnInfo.getPrecision, columnInfo.getScale), containsNull = true)
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/684//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/684//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/684//console
This message is automatically generated.
> Spark integration doesn't work with decimal columns that are using default
> precision
> ------------------------------------------------------------------------------------
>
> Key: PHOENIX-3504
> URL: https://issues.apache.org/jira/browse/PHOENIX-3504
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Sergey Soldatov
> Assignee: Sergey Soldatov
> Attachments: PHOENIX-3504-1.patch
>
>
> Not sure when this issue was introduced and whether this code was working
> well before, but in PhoenixRDD.phoenixTypeToCatalystType for decimal
> precision we have a check
> (columnInfo.getPrecision < 0)
> which is fail for decimal columns that were created with default precision
> and scale because precision is null in this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
