[
https://issues.apache.org/jira/browse/PHOENIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707259#comment-15707259
]
James Taylor commented on PHOENIX-3351:
---------------------------------------
This patch definitely looks like an improvement based on the amount of code it
removes. How about if we pull it in (once [~maryannxue]'s comments are
addressed) and then figure out how to leverage system columns next?
The goal should be to remove all validation logic from Phoenix and let Calcite
do that. There's still quite a bit of validation logic that we shouldn't need
to do.
> Implement TODOs in PhoenixTableModify#upsert to allow writes to tenant
> specific tables
> --------------------------------------------------------------------------------------
>
> Key: PHOENIX-3351
> URL: https://issues.apache.org/jira/browse/PHOENIX-3351
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Attachments: PHOENIX-3351_WIP.patch
>
>
> While running UDF IT tests came across this TODO which is necessary to
> implement for tenant specific, local or view indexes tests to pass.
> {noformat}
> // TODO TenantId, ViewIndexId, UpdatableViewColumns
> final List<PColumn> mappedColumns =
> targetTable.tableMapping.getMappedColumns();
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
