[ 
https://issues.apache.org/jira/browse/PHOENIX-3511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709281#comment-15709281
 ] 

James Taylor commented on PHOENIX-3511:
---------------------------------------

Thanks for the patch, [~singamteja]. We shouldn't hard code config values, 
though. Instead, use the config.setIfUnset() method. If you're setting HBase 
config parameters that already have default values (in which case the 
config.setIfUnset() would not set the value since it's already set), then you 
can do the following instead:
- Create a new Phoenix config parameter (see QueryServices as that's where 
they're all defined). These new config parameters would define a minimum or 
maximum value for the HBase configs.
- In PhoenixMRJobSubmitter, retrieve the HBase config parameter and the Phoenix 
config parameter. Only set the HBase config parameter if it's smaller/larger 
than the Phoenix config parameter.

[~tdsilva] - would you mind reviewing the next revision of the patch?

> Async Secondary index MR job fails for large data > 200 M records
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-3511
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3511
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.0
>            Reporter: Loknath Priyatham Teja Singamsetty 
>            Assignee: Loknath Priyatham Teja Singamsetty 
>             Fix For: 4.9.0, 4.9.1
>
>         Attachments: phoenix-3511.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to