[
https://issues.apache.org/jira/browse/PHOENIX-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716146#comment-15716146
]
Hadoop QA commented on PHOENIX-541:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12841538/PHOENIX-541.patch
against master branch at commit 683e1f0fe8f61e6c01f766a9d25ca3e953691464.
ATTACHMENT ID: 12841538
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ PhoenixConnection connection = (PhoenixConnection)
DriverManager.getConnection(getUrl(), connectionProperties);
+ List<List<Mutation>> mutationBatchList =
getMutationBatchList(maxSize, maxSizeBytes, mutationList);
+ public static List<List<Mutation>> getMutationBatchList(long maxSize, long
maxSizeBytes, List<Mutation> allMutationList) {
+ if (currentList.size() == maxSize || currentBatchSizeBytes +
mutationSizeBytes > maxSizeBytes) {
+ this.mutateBatchSizeBytes = JDBCUtil.getMutateBatchSizeBytes(url,
this.info, this.services.getProps());
+ public static long getMutateBatchSizeBytes(String url, Properties info,
ReadOnlyProps props) throws SQLException {
+ String batchSizeStr = findProperty(url, info,
PhoenixRuntime.UPSERT_BATCH_SIZE_BYTES_ATTRIB);
+ return (batchSizeStr == null ?
props.getLong(QueryServices.MUTATE_BATCH_SIZE_BYTES_ATTRIB,
QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE_BYTES) :
Long.parseLong(batchSizeStr));
+ * @param dataTypes - Initialized empty list to be filled with the
corresponding data type for the columns in @param columns.
+ PhoenixConnection connection = (PhoenixConnection)
DriverManager.getConnection(getUrl(), connectionProperties);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/694//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/694//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/694//console
This message is automatically generated.
> Make mutable batch size bytes-based instead of row-based
> --------------------------------------------------------
>
> Key: PHOENIX-541
> URL: https://issues.apache.org/jira/browse/PHOENIX-541
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 3.0-Release
> Reporter: mujtaba
> Assignee: Geoffrey Jacoby
> Labels: newbie
> Fix For: 4.10.0
>
> Attachments: PHOENIX-541.patch
>
>
> With current configuration of row-count based mutable batch size, ideal value
> for batch size is around 800 rather then current 15k when creating indexes
> based on memory consumption, CPU and GC (data size: key: ~60 bytes, 14
> integer column in separate CFs)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
