[
https://issues.apache.org/jira/browse/PHOENIX-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749520#comment-15749520
]
Josh Elser commented on PHOENIX-3531:
-------------------------------------
Hey [~kliew].
Looks like this one duplicates the spirit behind PHOENIX-1824.
I will say, as I started hacking on this a long time ago, I wasn't happy with
what the extra tests were really gaining us. In actuality, they were really
just re-testing things in Avatica. I think trying to re-run every IT would be
more of a waste of CPU time than actually providing us worth.
I think efforts to increase PQS testing in Phoenix would be better served doing
some very high-level tests to verify that functionality works.
> Apply integration tests to the queryserver
> ------------------------------------------
>
> Key: PHOENIX-3531
> URL: https://issues.apache.org/jira/browse/PHOENIX-3531
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 4.8.0
> Reporter: Kevin Liew
> Assignee: Kevin Liew
> Priority: Minor
> Labels: integration-tests, test-framework
>
> We can add queryserver tests that extend the direct tests.
> ie. QueryServerLikeExpressionIT extends LikeExpressionIT.
> `getUrl` needs to be overridden to access the test cluster through the
> queryserver. We can't override static methods or fields (but getUrl needs to
> be static because in many cases it is used in @BeforeClass) but we could use
> dependency injection to inject a url-holder. This way, the QueryServer~IT
> tests will be shell classes that simply override initialization of the
> url-holder.
> This could effectively double the amount of time taken to run integration
> tests.
> Any objections to using dependency injection - or alternative solutions?
> Should we replicate tests across the board or selectively?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
