[ https://issues.apache.org/jira/browse/PHOENIX-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810815#comment-15810815 ]
Hadoop QA commented on PHOENIX-3567: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12846259/PHOENIX-3567.002.patch against master branch at commit d8f4594989c0b73945aaffec5649a0b62ac59724. ATTACHMENT ID: 12846259 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation, build, or dev patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 43 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + parser.add_argument('-u', '--user', help='Username for database authentication (unsupported).', default='none') + parser.add_argument('-p', '--password', help='Password for database authentication (unsupported).', default='none') + parser.add_argument('-fc', '--fastconnect', help='Fetch all schemas on initial connection', default='false') + " --color=" + colorSetting + " --fastConnect=" + args.fastconnect + " --verbose=" + args.verbose + \ +parser.add_argument('zookeepers', nargs='?', help='The ZooKeeper quorum string', default='localhost:2181:/hbase') + ' -cp "' + hbase_config_path + os.pathsep + phoenix_utils.hbase_conf_dir + os.pathsep + phoenix_utils.phoenix_client_jar + \ + " -n " + args.user + " -p " + args.password + " --color=" + colorSetting + " --fastConnect=" + args.fastconnect + \ + " --verbose=" + args.verbose + " --incremental=false --isolation=TRANSACTION_READ_COMMITTED " + sqlfile {color:green}+1 core tests{color}. The patch passed unit tests in . {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/719//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/719//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/719//console This message is automatically generated. > Use argparse in sqlline.py > -------------------------- > > Key: PHOENIX-3567 > URL: https://issues.apache.org/jira/browse/PHOENIX-3567 > Project: Phoenix > Issue Type: Improvement > Reporter: Josh Elser > Assignee: Josh Elser > Fix For: 4.10.0 > > Attachments: PHOENIX-3567.001.patch, PHOENIX-3567.002.patch > > > Corollary to PHOENIX-3517 for sqlline.py. -- This message was sent by Atlassian JIRA (v6.3.4#6332)