[
https://issues.apache.org/jira/browse/PHOENIX-3611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832640#comment-15832640
]
Hadoop QA commented on PHOENIX-3611:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12848639/PHOENIX-3611-v2.patch
against master branch at commit 4e4f7ddba9bddec94793e92698346dedfb520c9e.
ATTACHMENT ID: 12848639
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ int maxCacheDuration =
config.getInt(QueryServices.CLIENT_CONNECTION_CACHE_MAX_DURATION_MILLISECONDS,
+ public void onRemoval(RemovalNotification<ConnectionInfo,
ConnectionQueryServices> notification) {
+ logger.error("Error while closing expired cache
connection " + connInfoIdentifier, se);
+ protected ConnectionQueryServices getConnectionQueryServices(String url,
final Properties info) throws SQLException {
+ connectionQueryServicesCache.get(normalizedConnInfo, new
Callable<ConnectionQueryServices>() {
+ connectionQueryServices = new
ConnectionlessQueryServicesImpl(services, normalizedConnInfo, info);
+ connectionQueryServices = new
ConnectionQueryServicesImpl(services, normalizedConnInfo, info);
+ public static final String CLIENT_CONNECTION_CACHE_MAX_SIZE =
"phoenix.client.connection.cache.max.size";
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/740//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/740//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/740//console
This message is automatically generated.
> ConnectionQueryService cache should expire LRU entries
> ------------------------------------------------------
>
> Key: PHOENIX-3611
> URL: https://issues.apache.org/jira/browse/PHOENIX-3611
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.8.0, 4.9.0
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Attachments: PHOENIX-3611.patch, PHOENIX-3611-v2.patch
>
>
> Currently the cache of ConnectionInfo/ConnectionQueryServicesImpl can hold
> its entries forever. This can potentially lead to orphan cache entries, and
> since each ConnectionQueryServicesImpl object has an HConnection, it can also
> lead to leaked connections.
> Due to the way that ConnectionInfo hashing works (see PHOENIX-3126 and
> PHOENIX-3607), this is particularly likely on a secure cluster.
> The cache should be changed into an LRU-style cache with a fixed size and
> gradual expiration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
