[ 
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861797#comment-15861797
 ] 

Josh Elser commented on PHOENIX-3655:
-------------------------------------

bq. My understanding is PQS comes with Phoenix driver. The client of the 
phoenix driver needs to make specific calls to PhoenixRuntime to generate the 
metrics and push it to the sink. 

Yes, you're right, but PQS is doing _more_ than just making calls to that JDBC 
driver. Exposing the existing metrics would be good, but I just wanted to be 
clear that it is not a complete solution. It would be misleading from an 
end-user perspective.

bq. Htrace would be not a good substitute for metrics collection

I didn't mean to suggest it as a replacement, but supplemental. Metrics are 
good for telling you how a certain piece of the system runs, but these don't 
tell you anything about the "big picture" execution time (what users would 
actually care about -- time for them to see results on their screen). A good 
story to have.

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>             Fix For: 4.9.0
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. 
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix 
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need 
> capability to collect metrics at PQS level and push the data to external sink 
> i.e. file, JMX , other external custom sources. 
> 2. Besides this global metrics could be periodically collected and pushed to 
> the sink. 
> 2. PQS can be configured to turn on metrics collection and type of collect ( 
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to