[
https://issues.apache.org/jira/browse/PHOENIX-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated PHOENIX-3672:
----------------------------------
Attachment: PHOENIX-3672.patch
[~jamestaylor], [~tdsilva] - please review. The key change is in BaseQueryIT.
What I have done is that for every parameter combination, we generate a unique
table and index. The alternative was to generate index and tables in the
constructor but that slows down the tests considerably as then for every test
method for every parameter, we would be creating tables and indices. I have
provided isolation between methods running for a parameter by the usual clean
up method in BaseClientManagedIT class. I have overriden the @AfterClass method
though since we don't need to drop the tables as they are unique (unless some
other test class ends up using hardcoded table names like our generated table
names which is unlikely).
> Change tests extending BaseQueryIT to use unique table names
> ------------------------------------------------------------
>
> Key: PHOENIX-3672
> URL: https://issues.apache.org/jira/browse/PHOENIX-3672
> Project: Phoenix
> Issue Type: Task
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-3672.patch
>
>
> This is important for making sure we have good coverage for column encoding
> and any new features we will add.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
