[
https://issues.apache.org/jira/browse/PHOENIX-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872474#comment-15872474
]
Poorna Chandra edited comment on PHOENIX-3585 at 2/17/17 8:30 PM:
------------------------------------------------------------------
[~tdsilva] Looking at the implementation of
{{IndexHalfStoreFileReaderGenerator.preCompactScannerOpen}}, it looks like we
just add a {{LocalIndexStoreFileScanner}} to the scanner list when reader is an
instance of {{IndexHalfStoreFileReader}}. Can't
{{PhoenixTransactionalProcessor}} override
{{TransactionProcessor.preCompactScannerOpen}}, and add the
{{LocalIndexStoreFileScanner}} to {{scanners}} and then pass the {{scanners}}
to {{TransactionProcessor.preCompactScannerOpen}}?
Also, looking at code it is not clear why {{IndexHalfStoreFileReader}} needs
special handling. Could you explain it a bit here?
was (Author: poornachandra):
[~tdsilva] Looking at the implementation of
{{IndexHalfStoreFileReaderGenerator.preCompactScannerOpen}}, it looks like we
just add a {{LocalIndexStoreFileScanner}} to the scanner list when reader is an
instance of {{IndexHalfStoreFileReader}}. Can't we override
{{TransactionProcessor.preCompactScannerOpen}}, and add the
{{LocalIndexStoreFileScanner}} to {{scanners}} and then pass the {{scanners}}
to {{TransactionProcessor.preCompactScannerOpen}}?
Also, looking at code it is not clear why {{IndexHalfStoreFileReader}} needs
special handling. Could you explain it a bit here?
> MutableIndexIT testSplitDuringIndexScan and testIndexHalfStoreFileReader fail
> for transactional tables and local indexes
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3585
> URL: https://issues.apache.org/jira/browse/PHOENIX-3585
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Attachments: diff.patch
>
>
> the tests fail if we use HDFSTransactionStateStorage instead of
> InMemoryTransactionStateStorage when we create the TransactionManager in
> BaseTest
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
