[
https://issues.apache.org/jira/browse/PHOENIX-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879453#comment-15879453
]
Thomas D'Silva commented on PHOENIX-3585:
-----------------------------------------
In {{IndexHalfStoreFileReaderGenerator.preCompactScannerOpen}} if the internal
scanner that is passed in is not null, can we just use the Scan of the internal
scanner that is passed in ?
{code}
if (!store.getFamily().getNameAsString()
.startsWith(QueryConstants.LOCAL_INDEX_COLUMN_FAMILY_PREFIX)
- || s != null
|| !store.hasReferences()) {
return s;
}
List<StoreFileScanner> newScanners = new
ArrayList<StoreFileScanner>(scanners.size());
- Scan scan = new Scan();
- scan.setMaxVersions(store.getFamily().getMaxVersions());
+ Scan scan = null;
+ if (s!=null) {
+ scan = ((StoreScanner)s).scan;
+ } else {
+ scan = new Scan();
+ scan.setMaxVersions(store.getFamily().getMaxVersions());
+ }
{code}
> MutableIndexIT testSplitDuringIndexScan and testIndexHalfStoreFileReader fail
> for transactional tables and local indexes
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3585
> URL: https://issues.apache.org/jira/browse/PHOENIX-3585
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Attachments: diff.patch
>
>
> the tests fail if we use HDFSTransactionStateStorage instead of
> InMemoryTransactionStateStorage when we create the TransactionManager in
> BaseTest
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
