[ 
https://issues.apache.org/jira/browse/PHOENIX-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942820#comment-15942820
 ] 

Hadoop QA commented on PHOENIX-3753:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12860601/PHOENIX-3753_v1.patch
  against master branch at commit 2074d1f0a2dd2b03c2e3588ffd4d5f2395cc7505.
  ATTACHMENT ID: 12860601

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
45 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                    if ((table2.getBucketNum() != null && 
table2.getBucketNum() > 0) && (table1.getBucketNum() == null || 
table1.getBucketNum() == 0)) {
+                    } else if ((table2.getBucketNum() == null || 
table2.getBucketNum() == 0) && (table1.getBucketNum() != null && 
table1.getBucketNum() > 0)) {
+        conn.createStatement().execute("CREATE TABLE T (k1 varchar NOT NULL, 
k2 INTEGER NOT NULL, v1 INTEGER, v2 INTEGER, CONSTRAINT pk PRIMARY KEY (k1, 
k2)) IMMUTABLE_ROWS=true");

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DistinctPrefixFilterIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/813//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/813//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/813//console

This message is automatically generated.

> The salt index affects the query plan of the non-salt table
> -----------------------------------------------------------
>
>                 Key: PHOENIX-3753
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3753
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.0
>            Reporter: shenzongqiang
>         Attachments: PHOENIX-3753_v1.patch
>
>
> The salt index affects the query plan of the non-salt table,
> Can be reproduced by the following example:
> 1.Create table:
> CREATE TABLE IF NOT EXISTS test1 (
>       date varchar NOT NULL,
>       cust_id INTEGER NOT NULL,
>       agent_id INTEGER,
>       pay BIGINT,
>       click BIGINT,
>       pv BIGINT,
>       CONSTRAINT pk PRIMARY KEY (date, cust_id)
> );
> 2.Create index:
> CREATE INDEX ix_test1 ON test1(agent_id) INCLUDE (pay, click) SALT_BUCKETS = 
> 10;
> 3.Explain query:
> EXPLAIN SELECT SUM(pay), SUM(click) FROM test1 WHERE DATE = '2017-01-01';
> 4.Expected result:
> +---------------------------------------------------------------------+
> |                                PLAN                                 |
> +---------------------------------------------------------------------+
> | CLIENT 1-CHUNK PARALLEL 1-WAY RANGE SCAN OVER TEST1 ['2017-01-01']  |
> |     SERVER AGGREGATE INTO SINGLE ROW                                |
> +---------------------------------------------------------------------+
> 5.Actual results:
> +---------------------------------------------------------------------+
> |                                PLAN                                 |
> +---------------------------------------------------------------------+
> | CLIENT 10-CHUNK PARALLEL 10-WAY RANGE SCAN OVER IX_TEST1 [0] - [9]  |
> |     SERVER FILTER BY "DATE" = '2017-01-01'                          |
> |     SERVER AGGREGATE INTO SINGLE ROW                                |
> +---------------------------------------------------------------------+



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to