Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/229#discussion_r110057029
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryPlan.java ---
    @@ -59,6 +60,8 @@
          * Returns projector used to formulate resultSet row
          */
         RowProjector getProjector();
    +
    +    String getCursorName();
    --- End diff --
    
    I think an alternate implementation would be to have a CursorQueryPlan 
which wraps another QueryPlan. This would be similar to the way a UnionPlan was 
implemented. That way you wouldn't need to litter the other plan 
implementations with logic to wrap them with the CursorResultIterator (which 
would be brittle if/when new plans are added).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to