[
https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003036#comment-16003036
]
Hadoop QA commented on PHOENIX-2885:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12866937/PHOENIX-2885.4.10-HBase-0.98.patch
against master branch at commit 37d0a4a038c1f843db2a1d68cfc3b3cfa8c8d537.
ATTACHMENT ID: 12866937
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "select TABLE_NAME,UPDATE_CACHE_FREQUENCY from SYSTEM.CATALOG
where TABLE_NAME = '"+TABLE_NAME+"' AND TABLE_TYPE='u'";
+ props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
""+defaultUpdateCacheFrequency);
+ "select TABLE_NAME,UPDATE_CACHE_FREQUENCY from SYSTEM.CATALOG where
TABLE_NAME = '"+TABLE_NAME+"' AND TABLE_TYPE='u'");
+ public static final String DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB =
"phoenix.default.update.cache.frequency";
+ getLong(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FERQUENCY);
+ getLong(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB,
QueryServicesOptions.DEFAULT_UPDATE_CACHE_FERQUENCY);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CreateTableIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/850//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/850//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/850//console
This message is automatically generated.
> Set default value for UPDATE_CACHE_FREQUENCY
> --------------------------------------------
>
> Key: PHOENIX-2885
> URL: https://issues.apache.org/jira/browse/PHOENIX-2885
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-2885.4.10-HBase-0.98.patch
>
>
> We have the ability currently to tell Phoenix how stale we're will to have
> the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when
> a table is created, unless explicitly specified, there is no
> UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration
> parameter to specify a default value when a CREATE TABLE statement is
> executed. In addition, when a VIEW is created, we should inherit the
> UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly
> specified) and then fallback to the new default config value.
> [1] https://phoenix.apache.org/language/index.html#options
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
