[
https://issues.apache.org/jira/browse/PHOENIX-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003310#comment-16003310
]
James Taylor commented on PHOENIX-3734:
---------------------------------------
Thanks for the patch, [~ohads]. [~tdsilva] committed PHOENIX-3671 to the omid
feature branch (which was based off of master). Is this patch on top of that
work? Does it work for you to keep this on the omid feature branch based off of
master? We can take this pull as the basis for that branch. This will require
more merging on your part to keep your feature branch in sync with master. If
we want this to come into the mainline branches, we'll want to see if we can
maintain b/w compatibility. Not mandatory because transactions are still a beta
feature, but it's more of a nice to have. Did any over-the-wire serialization
change with this pull? It seems not. Have you had a chance to run {{mvn
verify}} to make sure there are no regressions?
One minor nit: how about we rename
PhoenixTransactionContext.get_famility_delete_marker() to
getFamilyDeleteMarker()?
> Refactor Phoenix to use TAL instead of direct calls to Tephra
> -------------------------------------------------------------
>
> Key: PHOENIX-3734
> URL: https://issues.apache.org/jira/browse/PHOENIX-3734
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Ohad Shacham
> Assignee: Ohad Shacham
>
> Refactor Phoenix to use the new transaction abstraction layer instead of
> direct calls to Tephra. Once this task will be committed, Phoenix will
> continue working with Tephra but will have the option for fast integration of
> new transaction processing engines.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
