[ https://issues.apache.org/jira/browse/PHOENIX-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004259#comment-16004259 ]
Hadoop QA commented on PHOENIX-3843: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12867265/PHOENIX-3843.patch against master branch at commit 37d0a4a038c1f843db2a1d68cfc3b3cfa8c8d537. ATTACHMENT ID: 12867265 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 47 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + .SELECT_COLUMN_NUM_IN_UNIONALL_DIFFS).setMessage("1st query has " + columnCount + " columns whereas 2nd " + + + targetTypes.get(i).getType().getSqlTypeName() + " in 1st query where as it is " + String create = "CREATE TABLE s.t1 (k integer not null primary key, f1.v1 varchar, f1.v2 varchar, " + + create = "CREATE TABLE s.t2 (k integer not null primary key, f1.v1 varchar, f1.v2 varchar, f2.v3 varchar)"; + assertEquals(e.getMessage(), "ERROR 525 (42902): SELECT column number differs in a Union All query " + + String create = "CREATE TABLE s.t1 (k integer not null primary key, f1.v1 varchar, f1.v2 varchar, " + + create = "CREATE TABLE s.t2 (k integer not null primary key, f1.v1 varchar, f1.v2 integer, " + + assertEquals(e.getMessage(), "ERROR 526 (42903): SELECT column types differ in a Union All query " + + "is not allowed. Column # 2 is VARCHAR in 1st query where as it is INTEGER in 2nd query"); {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/855//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/855//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/855//console This message is automatically generated. > Improve logging for UNION ALL errors > ------------------------------------ > > Key: PHOENIX-3843 > URL: https://issues.apache.org/jira/browse/PHOENIX-3843 > Project: Phoenix > Issue Type: Improvement > Reporter: Sergey Soldatov > Assignee: Sergey Soldatov > Priority: Minor > Fix For: 4.11 > > Attachments: PHOENIX-3843.patch > > > At the moment if there are hundreds of columns in UNION ALL query it's quite > hard to understand why the query fails. At least we may report how the number > of columns are differ and which column has incompatible data type. -- This message was sent by Atlassian JIRA (v6.3.15#6346)