[
https://issues.apache.org/jira/browse/PHOENIX-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005389#comment-16005389
]
Hadoop QA commented on PHOENIX-3811:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12867407/PHOENIX-3811_v2.patch
against master branch at commit 37d0a4a038c1f843db2a1d68cfc3b3cfa8c8d537.
ATTACHMENT ID: 12867407
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public MutableIndexFailureIT(boolean transactional, boolean
localIndex, boolean isNamespaceMapped, Boolean disableIndexOnWriteFailure,
Boolean rebuildIndexOnWriteFailure) {
+ + (disableIndexOnWriteFailure == null ? "" : (", " +
PhoenixIndexFailurePolicy.DISABLE_INDEX_ON_WRITE_FAILURE + "=" +
disableIndexOnWriteFailure))
+ + (rebuildIndexOnWriteFailure == null ? "" : (", " +
PhoenixIndexFailurePolicy.REBUILD_INDEX_ON_WRITE_FAILURE + "=" +
rebuildIndexOnWriteFailure));
+ this.leaveIndexActiveOnFailure = ! (disableIndexOnWriteFailure == null
? QueryServicesOptions.DEFAULT_INDEX_FAILURE_DISABLE_INDEX :
disableIndexOnWriteFailure);
+ serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB,
Boolean.TRUE.toString());
+ Map<String, String> clientProps =
Collections.singletonMap(QueryServices.TRANSACTIONS_ENABLED,
Boolean.TRUE.toString());
+ @Parameters(name =
"MutableIndexFailureIT_transactional={0},localIndex={1},isNamespaceMapped={2},disableIndexOnWriteFailure={3},rebuildIndexOnWriteFailure={4}")
// name is used by failsafe as file name in reports
+ "CREATE " + (localIndex ? "LOCAL " : "") + " INDEX " +
indexName + " ON " + fullTableName + " (v1) INCLUDE (v2)");
+ "CREATE " + (!localIndex ? "LOCAL " : "") + " INDEX " +
secondIndexName + " ON " + fullTableName + " (v2) INCLUDE (v1)");
+// "CREATE " + (localIndex ? "LOCAL " : "") + " INDEX " +
thirdIndexName + " ON " + fullTableName + " (v1) INCLUDE (v2)");
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ReadOnlyIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CastAndCoerceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/857//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/857//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/857//console
This message is automatically generated.
> Do not disable index on write failure by default
> ------------------------------------------------
>
> Key: PHOENIX-3811
> URL: https://issues.apache.org/jira/browse/PHOENIX-3811
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3811_v1.patch, PHOENIX-3811_v2.patch,
> PHOENIX-3811-wip1.patch, PHOENIX-3811-wip2.patch, PHOENIX-3811-wip3.patch,
> PHOENIX-3811-wip4.patch, PHOENIX-3811-wip5.patch, PHOENIX-3811-wip7.patch
>
>
> We should provide a way to configure the system so that the server takes no
> specific action when an index write fails. Since we always throw the write
> failure back to the client, the client can often deal with failures more
> easily than the server since they have the batch of mutations in memory.
> Often times, allowing access to an index that may be one batch behind the
> data table is better than disabling it given the negative performance that
> will occur while the index cannot be written to.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
