[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008612#comment-16008612 ]
ASF GitHub Bot commented on PHOENIX-3655: ----------------------------------------- Github user rahulsIOT commented on a diff in the pull request: https://github.com/apache/phoenix/pull/242#discussion_r116309097 --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/metrics/sink/PqsSlf4jSink.java --- @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.queryserver.metrics.sink; + + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class PqsSlf4jSink extends PqsSink { + + private Logger logger = LoggerFactory.getLogger(PqsSlf4jSink.class);; + + public PqsSlf4jSink(){ + } + + @Override + public void close() {} + + @Override + public void writeJson(String json){ + if (json != null) + { + if (logger.isInfoEnabled()) + logger.info(json); --- End diff -- I think the following makes sense. i.e. if logging level is set to debug , then log both global and request level metrics. But if logging level is set to info, then we log only request level metrics only. Do you agree ? > Metrics for PQS > --------------- > > Key: PHOENIX-3655 > URL: https://issues.apache.org/jira/browse/PHOENIX-3655 > Project: Phoenix > Issue Type: New Feature > Affects Versions: 4.8.0 > Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98 > Reporter: Rahul Shrivastava > Assignee: Rahul Shrivastava > Fix For: 4.9.0 > > Attachments: MetricsforPhoenixQueryServerPQS.pdf > > Original Estimate: 240h > Remaining Estimate: 240h > > Phoenix Query Server runs a separate process compared to its thin client. > Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix > driver level. We need the following > 1. For every jdbc statement/prepared statement/ run by PQS , we need > capability to collect metrics at PQS level and push the data to external sink > i.e. file, JMX , other external custom sources. > 2. Besides this global metrics could be periodically collected and pushed to > the sink. > 2. PQS can be configured to turn on metrics collection and type of collect ( > runtime or global) via hbase-site.xml > 3. Sink could be configured via an interface in hbase-site.xml. > All metrics definition https://phoenix.apache.org/metrics.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)