Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r116561507
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java 
---
    @@ -185,7 +188,10 @@ private QueryPlan getQueryPlan(final JobContext 
context, final Configuration con
                     scan.setAttribute(BaseScannerRegionObserver.TX_SCN, 
Bytes.toBytes(Long.valueOf(txnScnValue)));
                 }
                 // Initialize the query plan so it sets up the parallel scans
    -            queryPlan.iterator(MapReduceParallelScanGrouper.getInstance());
    +            if(snapshotName != null)
    --- End diff --
    
    Add an init method to the ParallelScanGrouper interface that returns an 
instance and have the TableMRParallelScanGrouper implementation of that return 
TableMRParallelScanGrouper.getInstance(). We shouldn't need switching logic 
here based on snapshotName.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to