Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/248#discussion_r116625600
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java
---
@@ -107,12 +107,14 @@ public void testAddNewColumnsToBaseTableWithViews()
throws Exception {
assertTableDefinition(conn, tableName, PTableType.TABLE, null,
0, 3, QueryConstants.BASE_TABLE_BASE_COLUMN_COUNT, "ID", "COL1", "COL2");
viewConn.createStatement().execute("CREATE VIEW " +
viewOfTable + " ( VIEW_COL1 DECIMAL(10,2), VIEW_COL2 VARCHAR ) AS SELECT * FROM
" + tableName);
- assertTableDefinition(conn, viewOfTable, PTableType.VIEW,
tableName, 0, 5, 3, "ID", "COL1", "COL2", "VIEW_COL1", "VIEW_COL2");
+ assertTableDefinition(conn, viewOfTable, PTableType.VIEW,
tableName, 0, 5, 3, "VIEW_COL1", "VIEW_COL2");
--- End diff --
Are these test changes due to only storing diffs now? Would be nice to keep
the check for "this is what the combined table should look like" in addition to
checking that only the diffs are actually stored. WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
