Hi Josh, Understood. According to this https://github.com/git/git/blob/master/gitweb/gitweb.perl#L6029 the "tag" link is only present if the tag is a... tag? Weird.
Lars On Tue, May 16, 2017 at 5:23 PM, Josh Elser <[email protected]> wrote: > LarsG, > > Hrm, I don't know enough about git-web to say why these entries in the > "Tags" header don't have the "tag" anchor. Check the code itself, these tags > exist. See you for yourself: > > $ git clone https://git-wip-us.apache.org/repos/asf/phoenix.git && cd > phoenix > $ git tag | fgrep 4.8.2 > > And, again, the mis-naming was likely accidental. We should fix this. > > - Josh > > > Lars George wrote: >> >> Hi Josh, >> >> I think the point LarsF was making is that there are tags missing for >> 4.8.2, it is only the commits as you stated. See >> >> https://www.dropbox.com/s/xh3g008te08mwbg/Screenshot%202017-05-15%2008.32.45.png?dl=0 >> for reference of what we are seeing (which has no "tag" link to those >> commits). No worries, it is OK to use the commit hashes, we were >> merely wondering why they were not tagged, and also why the naming >> changed. >> >> Cheers, >> Lars >> >> On Tue, May 9, 2017 at 1:59 AM, Josh Elser<[email protected]> wrote: >>> >>> Hi Lars, >>> >>> The tags for 4.8.2 are: >>> >>> >>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=3d4205123f763fdfd875211d551da42deeb78412 >>> >>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=40de1f6cd5326b2c8ec2da5ad817696e050c2f3a >>> >>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=e7c63d54c592bbed193841a68c0f8717831258d9 >>> >>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=cf6c4f7c44ac64ada9e61385c4b10ef00e06b014 >>> >>> You can navigate to them via the git-web and the "tags" section. These >>> get >>> collapsed into a single "ref" (as both the official 4.8.2 release and rc2 >>> are the same thing -- rc2 was the vote that passed). >>> >>> Re: the missing "v" in "v4.x.y", I think this was just an accidental >>> omission. We can probably rectify this (add a tag which follows the >>> standard >>> naming). >>> >>> Re: the missing tags on Github, this is probably just ASF infra having >>> trouble. They control the mirroring process of all Git changes flowing to >>> the Github mirror. Sometimes this process gets out of whack, I have no >>> reason to believe this is anything other than that :) >>> >>> >>> Lars Francke wrote: >>>> >>>> Hi everyone, >>>> >>>> I am the first to admit that I don't fully understand all of git so I'm >>>> hoping you guys can help me. We're trying to check out the release bits >>>> of >>>> the 4.8.2 release. >>>> >>>> On Github there's no tag to be found for this release. >>>> >>>> The links from the vote thread< >>>> >>>> >>>> https://lists.apache.org/thread.html/9d5725264517e4e93f610b8b117a735a75e90cf81d96154df9b2bda3@%3Cdev.phoenix.apache.org%3E> >>>> lead to 404s< >>>> >>>> >>>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tag;h=refs/tags/4.8.2-HBase-1.2-rc2 >>>>> >>>>> . >>>> >>>> >>>> The "tags" overview in Git does have a commit for 4.8.2< >>>> https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=tags> but the >>>> "tag" >>>> link at the end is missing. >>>> >>>> The "tag" also differs from previous releases in that the "v" at the >>>> beginning is missing. >>>> >>>> Compare this to 4.8.1:< >>>> >>>> >>>> https://lists.apache.org/thread.html/91683a340dd69cfcad15dd6ba6af1f497f317baadf13e7b22bc09e57@%3Cdev.phoenix.apache.org%3E >>>> >>>> Can anyone shed some light on the issue? >>>> >>>> Thanks, >>>> Lars >>>> >
