[ https://issues.apache.org/jira/browse/PHOENIX-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018005#comment-16018005 ]
Hadoop QA commented on PHOENIX-3834: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12869048/PHOENIX-3834.patch against master branch at commit bd27512666904a727adcd71b13725b02e655902b. ATTACHMENT ID: 12869048 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 47 warning messages. {color:red}-1 release audit{color}. The applied patch generated 3 release audit warnings (more than the master's current 0 warnings). {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + String sql = "SELECT ta.c1.a, ta.c2.b FROM " + tableA + " ta JOIN " + tableB + " tb ON ta.k = tb.k" ; + String sql = "SELECT /*+ USE_SORT_MERGE_JOIN */ ta.c1.a, ta.c2.b FROM " + tableA + " ta JOIN " + tableB + " tb ON ta.k = tb.k" ; + private static Pair<Long, Long> getByteRowEstimates(Connection conn, String sql, List<Object> bindValues) throws Exception { + * @return estimated number of rows that will be scanned when this statement plan is been executed. + * @return estimated number of bytes that will be scanned when this statement plan is been executed. + ParallelIteratorFactory parallelIteratorFactory, GroupBy groupBy, Expression having) throws SQLException { + ExplainPlan exp = plan instanceof BaseQueryPlan ? new ExplainPlan(getPlanSteps(plan.iterator())) : plan.getExplainPlan(); + QueryPlan plan, HashJoinInfo joinInfo, SubPlan[] subPlans, boolean recompileWhereClause, List<SQLCloseable> dependencies) throws SQLException { + Integer limit, Integer offset, OrderBy orderBy, ParallelIteratorFactory parallelIteratorFactory) throws SQLException { + Integer limit, Integer offset, OrderBy orderBy, ParallelIteratorFactory parallelIteratorFactory) throws SQLException { {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByCaseIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TransactionalViewIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/883//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/883//artifact/patchprocess/patchReleaseAuditWarnings.txt Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/883//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/883//console This message is automatically generated. > Provide a way to collect stats and not use it for query parallelization > ----------------------------------------------------------------------- > > Key: PHOENIX-3834 > URL: https://issues.apache.org/jira/browse/PHOENIX-3834 > Project: Phoenix > Issue Type: Improvement > Reporter: Samarth Jain > Assignee: Samarth Jain > Attachments: PHOENIX-3834.patch, PHOENIX-3834.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)