[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019833#comment-16019833
]
James Taylor commented on PHOENIX-3655:
---------------------------------------
[~elserj] - I think your review comments are most excellent, as always! Really
appreciate all of your insights.
One of the reasons we created our own client metrics collection was to capture
metrics per statement. We looked at using HTrace originally, but couldn't come
up with a way of supporting non global metrics ([~samarthjain] may remember
more details). We need to be able to answer questions like "What are the top
ten queries taking the most time?" and "Which queries are transferring over the
most bytes from the server?", etc.
IMHO, if we just can connect the dots in the right way between PQS and existing
Phoenix client side metrics for this JIRA, that would be a good goal. If that
can use existing libraries to do that without having to rework the Phoenix
client side metrics, then great. If not, then I think that's ok too - we can
file a follow up JIRA to clean this up for a 5.0 release where we have more
flexibility.
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Rahul Shrivastava
> Fix For: 4.9.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
