[
https://issues.apache.org/jira/browse/PHOENIX-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021652#comment-16021652
]
Hadoop QA commented on PHOENIX-3877:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12869505/PHOENIX-3877.patch
against master branch at commit 4471b87926094b71aff12c384f4fc60f87ff2915.
ATTACHMENT ID: 12869505
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
props.setProperty(QueryServices.CLIENT_CONNECTION_MAX_ALLOWED_CONNECTIONS,
Integer.toString(maxConnections));
+ attemptedPhoenixConnections <=
GLOBAL_PHOENIX_CONNECTIONS_ATTEMPTED_COUNTER.getMetric().getValue());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TransactionalViewIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/894//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/894//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/894//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/894//console
This message is automatically generated.
> Connection throttling doesn't always decrement on connection close
> ------------------------------------------------------------------
>
> Key: PHOENIX-3877
> URL: https://issues.apache.org/jira/browse/PHOENIX-3877
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.10.0
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Attachments: PHOENIX-3877.patch
>
>
> PHOENIX-3663 introduced optional connection throttling in the JDBC driver.
> While the throttling itself works properly, the decrement operation on
> connection close won't update the open connection count unless an unrelated
> setting, returnSequenceValues, is true. (This is because the connection
> counts were originally built for sequence logic.) The result is that once we
> throttle, we often can't un-throttle even after congestion abates.
> The decrement operation on connection close should also take place anytime
> the connection throttling is turned on.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
