[ 
https://issues.apache.org/jira/browse/PHOENIX-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021903#comment-16021903
 ] 

James Taylor edited comment on PHOENIX-3797 at 5/23/17 9:32 PM:
----------------------------------------------------------------

Had an offline discussion with [~lhofhansl] who enlightened me on this issue. 
The non-increasing bloom key exception is happening to catch that rows are 
being written in the wrong order during compaction. Understandably, HBase can't 
detect this without a severe performance hit. Though we're not creating bloom 
filters any longer, this issue would still occur. We'd only detect it when a 
query serviced by the index happens to return incorrect results.

[~rajeshbabu] - I think we need to get to the bottom of this one. WDYT?

How about we start by having an assertion in the local index compaction hook 
code for the row keys to always be increasing?


was (Author: jamestaylor):
Had an offline discussion with [~lhofhansl] who enlightened me on this issue. 
The non-increasing bloom key exception is happening to catch that rows are 
being written in the wrong order during compaction. Understandably, HBase can't 
detect this without a severe performance hit. Though we're not creating bloom 
filters any longer, this issue would still occur. We'd only detect it when a 
query serviced by the index happens to return incorrect results.

[~rajeshbabu] - I think we need to get to the bottom of this one. WDYT?

> Local Index - Compaction fails on table with local index due to 
> non-increasing bloom keys
> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3797
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3797
>             Project: Phoenix
>          Issue Type: Bug
>         Environment: Head of 4.x-HBase-0.98 with PHOENIX-3796 patch applied. 
> HBase 0.98.23-hadoop2
>            Reporter: Mujtaba Chohan
>            Priority: Blocker
>             Fix For: 4.11.0
>
>
> Compaction fails on table with local index.
> {noformat}
> 2017-04-19 16:37:56,521 ERROR 
> [RS:0;host:59455-smallCompactions-1492644947594] 
> regionserver.CompactSplitThread: Compaction failed Request = 
> regionName=FHA,00Dxx0000001gES005001xx000003DGPd,1492644985470.92ec6436984981cdc8ef02388005a957.,
>  storeName=L#0, fileCount=3, fileSize=44.4 M (23.0 M, 10.7 M, 10.8 M), 
> priority=7, time=7442973347247614
> java.io.IOException: Non-increasing Bloom keys: 
> 00Dxx0000001gES005001xx000003DGPd\x00\x00\x80\x00\x01H+&\xA1(00Dxx0000001gER001001xx000003DGPb01739544DCtf
>     after 
> 00Dxx0000001gES005001xx000003DGPd\x00\x00\x80\x00\x01I+\xF4\x9Ax00Dxx0000001gER001001xx000003DGPa017115434KTM
>    
>       at 
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.appendGeneralBloomfilter(StoreFile.java:960)
>       at 
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:996)
>       at 
> org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:428)
>       at 
> org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:276)
>       at 
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:64)
>       at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:121)
>       at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1154)
>       at 
> org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1559)
>       at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(CompactSplitThread.java:502)
>       at 
> org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:540)
>       at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>       at java.lang.Thread.run(Thread.java:722)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to