[
https://issues.apache.org/jira/browse/PHOENIX-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025395#comment-16025395
]
Hadoop QA commented on PHOENIX-3866:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12869917/PHOENIX-3866.patch
against master branch at commit 5f9cf15e272fc9d92a3165753ac2157396851bd6.
ATTACHMENT ID: 12869917
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ isProjectEmptyKeyValue = ((where == null ||
LiteralExpression.isTrue(where)) && !statement.isAggregate() &&
!statement.isDistinct()) || (where != null && where.requiresFinalEvaluation());
+ PhoenixConnection pconn = DriverManager.getConnection(getUrl(),
PropertiesUtil.deepCopy(TEST_PROPERTIES)).unwrap(PhoenixConnection.class);
+ pconn.createStatement().execute("create table test (mykey integer not
null primary key, A.COLA integer, B.COLB integer) IMMUTABLE_ROWS=true,
STORE_NULL=false, IMMUTABLE_STORAGE_SCHEME = ONE_CELL_PER_COLUMN,
DISABLE_WAL=true");
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DeleteIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.VariableLengthPKIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ProductMetricsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ImmutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CoalesceFunctionIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/904//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/904//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/904//console
This message is automatically generated.
> COUNT(col) should scan along required column families only
> ----------------------------------------------------------
>
> Key: PHOENIX-3866
> URL: https://issues.apache.org/jira/browse/PHOENIX-3866
> Project: Phoenix
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: James Taylor
> Priority: Minor
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3866.patch
>
>
> These two should be equivalent:
> {code}
> 0: jdbc:phoenix:localhost> select count(B.COLB) from test;
> +----------------+
> | COUNT(B.COLB) |
> +----------------+
> | 10054 |
> +----------------+
> 1 row selected (9.446 seconds)
> 0: jdbc:phoenix:localhost> select count(B.COLB) from test where B.COLB is not
> null;
> +----------------+
> | COUNT(B.COLB) |
> +----------------+
> | 10054 |
> +----------------+
> 1 row selected (0.028 seconds)
> {code}
> Clearly the plain COUNT is doing unnecessary work.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
