[
https://issues.apache.org/jira/browse/PHOENIX-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030680#comment-16030680
]
Hadoop QA commented on PHOENIX-3773:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12870520/PHOENIX-3733-v6.patch
against master branch at commit e3fc929e93715a359b4267db9f4d12706247a6a6.
ATTACHMENT ID: 12870520
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 Anti-pattern{color}. The patch appears to
have anti-pattern where BYTES_COMPARATOR was omitted:
protected TreeMap<byte[], LinkedList<byte[]>> topValues = new
TreeMap<byte[], LinkedList<byte[]>>(new ByteArrayComparator());.
{color:red}-1 Known Incompatible class{color}. The patch
appears to have incompatible classes:
protected TreeMap<byte[], LinkedList<byte[]>> topValues = new
TreeMap<byte[], LinkedList<byte[]>>(new ByteArrayComparator());.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail .
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java:[292,25]
cannot find symbol
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.0:compile (default-compile) on
project phoenix-core: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java:[292,25]
cannot find symbol
[ERROR] symbol: class FirstValuesFunction
[ERROR] location: class org.apache.phoenix.expression.ExpressionType
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :phoenix-core
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/936//console
This message is automatically generated.
> Implement FIRST_VALUES aggregate function
> -----------------------------------------
>
> Key: PHOENIX-3773
> URL: https://issues.apache.org/jira/browse/PHOENIX-3773
> Project: Phoenix
> Issue Type: New Feature
> Reporter: James Taylor
> Assignee: Loknath Priyatham Teja Singamsetty
> Labels: SFDC
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3733.v4.patch, PHOENIX-3733-v5.patch,
> PHOENIX-3733-v6.patch, PHOENIX-3773.patch, PHOENIX-3773.v2.patch,
> PHOENIX-3773.v3.patch
>
>
> Similar to FIRST_VALUE, but would allow the user to specify how many values
> to keep. This could use a MinMaxPriorityQueue under the covers and be much
> more efficient than using multiple NTH_VALUE calls to do the same like this:
> {code}
> SELECT entity_id,
> NTH_VALUE(user_id,1) WITHIN GROUP (ORDER BY last_read_date DESC) as
> nth1_user_id,
> NTH_VALUE(user_id,2) WITHIN GROUP (ORDER BY last_read_date DESC) as
> nth2_user_id,
> NTH_VALUE(user_id,3) WITHIN GROUP (ORDER BY last_read_date DESC) as
> nth3_user_id,
> count(*)
> FROM MY_TABLE
> WHERE tenant_id='00Dx0000000XXXX'
> AND entity_id in ('0D5x000000ABCD','0D5x000000ABCE')
> GROUP BY entity_id;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
