[ https://issues.apache.org/jira/browse/PHOENIX-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035263#comment-16035263 ]
Hadoop QA commented on PHOENIX-3895: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12871014/PHOENIX-3895.002.patch against master branch at commit 9b8235eb8febbdee648d800eb578617023071dcc. ATTACHMENT ID: 12871014 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 45 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + throw new IllegalArgumentException("Array data is required to be Object[] but data for " + return createArrayBytes(byteStream, oStream, arr, noOfElements, baseType, sortOrder, rowKeyOrderOptimizable); + String updateSql = "UPSERT INTO " + tableName + " values('" + i + "', " + "ARRAY[" + sb.toString() + "])"; + assertTrue("Expected array data to be an int array, but was " + untypedArrayData.getClass(), untypedArrayData instanceof Object[]); + try (PreparedStatement pstmt = conn.prepareStatement("UPSERT INTO " + tableName + " values(?, ?)")) { + assertTrue("Expected array data to be an int array, but was " + untypedArrayData.getClass(), untypedArrayData instanceof Object[]); + try (PreparedStatement pstmt = conn.prepareStatement("UPSERT INTO " + tableName + " values(?, ?)")) { + assertTrue("Expected array data to be an int array, but was " + untypedArrayData.getClass(), untypedArrayData instanceof Object[]); + assertEquals(Integer.toString(getArrayValueForOffset(arrayOffset)), arrayData[arrayOffset]); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.FlappingLocalIndexIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/985//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/985//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/985//console This message is automatically generated. > Update to Apache Calcite Avatica 1.10.0 > --------------------------------------- > > Key: PHOENIX-3895 > URL: https://issues.apache.org/jira/browse/PHOENIX-3895 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: Josh Elser > Fix For: 4.11.0 > > Attachments: PHOENIX-3895.001.patch, PHOENIX-3895.002.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)