[
https://issues.apache.org/jira/browse/PHOENIX-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041458#comment-16041458
]
Hadoop QA commented on PHOENIX-3836:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12871739/PHOENIX-3836.patch
against master branch at commit 9095b3ec87aef45138d62e5bbffdafee3e934d38.
ATTACHMENT ID: 12871739
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
50 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 5 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String q = "SELECT SUM(GUIDE_POSTS_ROW_COUNT) FROM
SYSTEM.STATS WHERE PHYSICAL_NAME = '" + tableName + "'";
+ assertEquals("Number of expected rows in stats table after update
stats didn't match!", numRows, rs.getInt(1));
+ conn.createStatement().executeUpdate("DELETE FROM SYSTEM.STATS
WHERE PHYSICAL_NAME = '" + tableName + "'");
+ try (HBaseAdmin admin =
conn.unwrap(PhoenixConnection.class).getQueryServices().getAdmin()) {
+ q = "SELECT SUM(GUIDE_POSTS_ROW_COUNT) FROM SYSTEM.STATS WHERE
PHYSICAL_NAME = '" + tableName + "'";
+ assertEquals("Number of expected rows in stats table after major
compaction didn't match", numRows, rs.getInt(1));
+ ImmutableBytesWritable row = new
ImmutableBytesWritable(c.getRowArray(), c.getRowOffset(), c.getRowLength());
+ * During compaction, it is possible that HBase will return a limited
number of key values when
+ * internalScanner.next() is called. To avoid counting a row more than
once we need to check whether
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NotQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SysTableNamespaceMappedStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TimezoneOffsetFunctionIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1029//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1029//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1029//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1029//console
This message is automatically generated.
> Estimated row count is twice the actual row count when stats are updated via
> major compaction
> ---------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3836
> URL: https://issues.apache.org/jira/browse/PHOENIX-3836
> Project: Phoenix
> Issue Type: Bug
> Reporter: Mujtaba Chohan
> Assignee: Samarth Jain
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3836.patch
>
>
> Estimated row count for a 2M table is 3986498 after stats updated via major
> compaction vs 1993250 with {{update statistics}}.
> {noformat}
> Explain plan for count(*) on 2M row table after major compaction:
> +--------------------------------------------------------------------------------------+
> | PLAN
> |
> +--------------------------------------------------------------------------------------+
> | CLIENT 364-CHUNK 3986498 ROWS 3774892993 BYTES PARALLEL 1-WAY FULL SCAN
> OVER T |
> | SERVER FILTER BY FIRST KEY ONLY
> |
> | SERVER AGGREGATE INTO SINGLE ROW
> |
> +--------------------------------------------------------------------------------------+
> Explain plan for count(*) on 2M row table after update statistics:
> +--------------------------------------------------------------------------------------+
> | PLAN
> |
> +--------------------------------------------------------------------------------------+
> | CLIENT 364-CHUNK 1993250 ROWS 3774892993 BYTES PARALLEL 1-WAY FULL SCAN
> OVER T |
> | SERVER FILTER BY FIRST KEY ONLY
> |
> | SERVER AGGREGATE INTO SINGLE ROW
> |
> +--------------------------------------------------------------------------------------+
> {noformat}
> Following schema was used with 2M rows and 10MB guidepost width:
> {noformat}
> CREATE TABLE IF NOT EXISTS T (PKA CHAR(15) NOT NULL, PKF CHAR(3) NOT NULL,
> PKP CHAR(15) NOT NULL, CRD DATE NOT NULL, EHI CHAR(15) NOT NULL, STD_COL
> VARCHAR, INDEXED_COL INTEGER,
> CONSTRAINT PK PRIMARY KEY ( PKA, PKF, PKP, CRD DESC, EHI))
> VERSIONS=1,MULTI_TENANT=true,IMMUTABLE_ROWS=true
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
