[
https://issues.apache.org/jira/browse/PHOENIX-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052580#comment-16052580
]
Josh Elser commented on PHOENIX-3807:
-------------------------------------
Just getting around to taking a look:
bq. Count of deployed secondary indexes by type. Will help understand and trend
index usage, or catch deploy of an unwanted index type.
I'm not sure about the value of this. I would have just looked at the number of
regions hosted by table that the Region already has. I'm not -1 on including
it, just figured it was worth a mention.
Otherwise, the changes look pretty good.
On the naming of the metrics: instead of "IndexWriteCompletionTime" is
"IndexWriteTime" sufficient? I thought that would make it closer to its sister
"IndexPrepareTime". Similarly, for "IndexTotalUpdateCount", would
"GlobalIndexUpdateCount" make more sense (best as I can tell, this is the total
number of index updates across all tables). I like that these are much more
"high-level" consumable -- my patch was primarily re-using the terminology on
the coprocessor itself (e.g. preBatchMutate, postBatchMutateIndispensably).
> Add server level metrics for secondary indexes
> ----------------------------------------------
>
> Key: PHOENIX-3807
> URL: https://issues.apache.org/jira/browse/PHOENIX-3807
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Vincent Poon
> Attachments: PHOENIX-3807.v1.master.patch, Screen Shot 2017-05-31 at
> 4.00.16 PM.png
>
>
> Add server level metrics for secondary indexes
> - Histogram metrics for time to complete all secondary index updates per
> primary table update per index type. Will help us trend perf over time and
> catch impending issues.
> - Histogram metrics for number of updates dispatched to secondary index
> stores to service one primary table update per index type. Will help us catch
> inefficient behavior or problematic schema design.
> - Count of deployed secondary indexes by type. Will help understand and trend
> index usage, or catch deploy of an unwanted index type.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
