[
https://issues.apache.org/jira/browse/PHOENIX-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059256#comment-16059256
]
ASF GitHub Bot commented on PHOENIX-3944:
-----------------------------------------
Github user brfrn169 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/261#discussion_r123493994
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -1420,7 +1420,7 @@ public MetaDataMutationResult createTable(final
List<Mutation> tableMetaData, fi
byte[] tenantIdBytes =
rowKeyMetadata[PhoenixDatabaseMetaData.TENANT_ID_INDEX];
byte[] schemaBytes =
rowKeyMetadata[PhoenixDatabaseMetaData.SCHEMA_NAME_INDEX];
byte[] tableBytes =
rowKeyMetadata[PhoenixDatabaseMetaData.TABLE_NAME_INDEX];
- byte[] tableName = physicalTableName != null ? physicalTableName :
SchemaUtil.getTableNameAsBytes(schemaBytes, tableBytes);
+ byte[] tableName = SchemaUtil.getTableNameAsBytes(schemaBytes,
tableBytes);
--- End diff --
I think this is correct because this variable is used as the first argument
of ensureTableCreated method and it doesn't expect a physical table name but a
phoenix table name.
Also, this variable is used by the following code but it expects a phoenix
table name as well.
```
ensureViewIndexTableCreated(
SchemaUtil.getPhysicalHBaseTableName(tableName,
isNamespaceMapped, tableType).getBytes(),
tableProps, familiesPlusDefault,
MetaDataUtil.isSalted(m, kvBuilder, ptr) ? splits : null,
MetaDataUtil.getClientTimeStamp(m),
isNamespaceMapped);
```
> ReadOnlyTableException occurs when we map Phoenix view to an existing HBase
> table with Namespace Mapping enabled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3944
> URL: https://issues.apache.org/jira/browse/PHOENIX-3944
> Project: Phoenix
> Issue Type: Bug
> Reporter: Toshihiro Suzuki
>
> Firstly, I created a namespace and a table in hbase shell:
> {code}
> hbase> create_namespace "NS"
> hbase> create "NS:TBL", "CF"
> {code}
> After that, I tried to create a phoenix view for this existing hbase table in
> phoenix-sqlline:
> {code}
> phoenix> CREATE VIEW ns.tbl (pk VARCHAR PRIMARY KEY, cf.col VARCHAR);
> {code}
> However, I encountered the following error and I was not able to create the
> view:
> {code}
> org.apache.phoenix.schema.ReadOnlyTableException: ERROR 505 (42000): Table is
> read only.
> at
> org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureTableCreated(ConnectionQueryServicesImpl.java:1072)
> at
> org.apache.phoenix.query.ConnectionQueryServicesImpl.createTable(ConnectionQueryServicesImpl.java:1434)
> at
> org.apache.phoenix.schema.MetaDataClient.createTableInternal(MetaDataClient.java:2624)
> at
> org.apache.phoenix.schema.MetaDataClient.createTable(MetaDataClient.java:1040)
> at
> org.apache.phoenix.compile.CreateTableCompiler$2.execute(CreateTableCompiler.java:212)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:393)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:376)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:375)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:363)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1707)
> at org.apache.PhoenixTest.main(PhoenixTest.java:55)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
