[ 
https://issues.apache.org/jira/browse/PHOENIX-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076766#comment-16076766
 ] 

Hadoop QA commented on PHOENIX-3944:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12875916/PHOENIX-3944_v4_4.x_HBase-1.2.patch
  against master branch at commit 0c2c696fdc87da0a3d41832966ada838e39954ec.
  ATTACHMENT ID: 12875916

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
47 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        physicalTableName = 
SchemaUtil.getPhysicalHBaseTableName(schemaName, tableName, 
userTableNamespaceMapped).getString();
+            String physicalTableName = 
SchemaUtil.getPhysicalTableName(Bytes.toBytes(fullTableName), 
userTableNamespaceMapped).toString();
+                + SchemaUtil.getPhysicalTableName(Bytes.toBytes(tableName), 
isNamespaceMapped) + " ['"
+                    + 
SchemaUtil.getPhysicalTableName(Bytes.toBytes(tableName), isNamespaceMapped) + 
" [1,'"
+                        
SchemaUtil.getPhysicalTableName(Bytes.toBytes(tableName), 
isNamespaceMapped).toBytes()))
+    public void 
testCreateViewMappedToExistingHbaseTableWithNamespaceMappingEnabled() throws 
Exception {
+            // test for a view whose name contains a dot (e.g. "AAA.BBB") in 
default schema (for backward compatibility)
+                "CLIENT PARALLEL 1-WAY RANGE SCAN OVER " + 
SchemaUtil.getPhysicalTableName(Bytes.toBytes(fullTableName), 
isNamespaceMapped) + " [1,'10',100]\n" +
+            String basePhysicalName = 
SchemaUtil.getPhysicalTableName(Bytes.toBytes(baseFullName), 
isNamespaceMapped).toString();
+                boolean isNamespaceMapped = 
SchemaUtil.isNamespaceMappingEnabled(statement.getTableType(), 
connection.getQueryServices().getProps());

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1163//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1163//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1163//console

This message is automatically generated.

> ReadOnlyTableException occurs when we map Phoenix view to an existing HBase 
> table with Namespace Mapping enabled
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3944
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3944
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>         Attachments: PHOENIX-3944.patch, PHOENIX-3944_v2.patch, 
> PHOENIX-3944_v3_4.x_HBase-1.2.patch, PHOENIX-3944_v3.patch, 
> PHOENIX-3944_v4_4.x_HBase-1.2.patch, PHOENIX-3944_v4.patch
>
>
> Firstly, I created a namespace and a table in hbase shell:
> {code}
> hbase> create_namespace "NS"
> hbase> create "NS:TBL", "CF"
> {code}
> After that, I tried to create a phoenix view for this existing hbase table in 
> phoenix-sqlline:
> {code}
> phoenix> CREATE VIEW ns.tbl (pk VARCHAR PRIMARY KEY, cf.col VARCHAR);
> {code}
> However, I encountered the following error and I was not able to create the 
> view:
> {code}
> org.apache.phoenix.schema.ReadOnlyTableException: ERROR 505 (42000): Table is 
> read only.
>       at 
> org.apache.phoenix.query.ConnectionQueryServicesImpl.ensureTableCreated(ConnectionQueryServicesImpl.java:1072)
>       at 
> org.apache.phoenix.query.ConnectionQueryServicesImpl.createTable(ConnectionQueryServicesImpl.java:1434)
>       at 
> org.apache.phoenix.schema.MetaDataClient.createTableInternal(MetaDataClient.java:2624)
>       at 
> org.apache.phoenix.schema.MetaDataClient.createTable(MetaDataClient.java:1040)
>       at 
> org.apache.phoenix.compile.CreateTableCompiler$2.execute(CreateTableCompiler.java:212)
>       at 
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:393)
>       at 
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:376)
>       at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
>       at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:375)
>       at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:363)
>       at 
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1707)
>       at org.apache.PhoenixTest.main(PhoenixTest.java:55)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to