[
https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084463#comment-16084463
]
Hadoop QA commented on PHOENIX-3978:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12876913/PHOENIX-3978-4.x-HBase-0.98-v3.patch
against 4.x-HBase-0.98 branch at commit
caeaec8355023ce93656f56ad6dfa77d5dbc3517.
ATTACHMENT ID: 12876913
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1202//console
This message is automatically generated.
> Expose mutation failures in our metrics
> ---------------------------------------
>
> Key: PHOENIX-3978
> URL: https://issues.apache.org/jira/browse/PHOENIX-3978
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-3978-4.x-HBase-0.98-v2.patch,
> PHOENIX-3978-4.x-HBase-0.98-v3.patch, PHOENIX-3978.patch,
> PHOENIX-3978-v2.patch
>
>
> We should be exposing whether a mutation has failed through our metrics
> system. This should be done both within global and request level metrics.
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in
> GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to
> MutationMetric class
> 4) Making sure that the two metrics are updated within the catch exception
> block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
