[
https://issues.apache.org/jira/browse/PHOENIX-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088695#comment-16088695
]
Samarth Jain commented on PHOENIX-4028:
---------------------------------------
[~jamestaylor] - Thanks for making the change in MutableIndexFailureIT. It
looks like that now with this change we are testing the failRebuildIndex code
path for only one case { false, false, false, true, true, true, null}.
The class should have more test cases where failRebuildTask is true.
Essentially covering this condition -
{code}
rebuildIndexOnWriteFailure && !transactional && !leaveIndexActiveOnFailure &&
!localIndex
{code}
which is what the test class was originally doing.
It would also be good to have tests in CreateTableIT and AlterTableIT that
check whether setting of this property through DDL works and that the property
ends up being a part of HTableDescriptor. My guess is that unless you add this
property to TableProperty, these tests won't pass. Also, we should be allowing
users to set this property only on data tables (indexes, views, etc can't have
it). Setting appropriate properties on the new enum in TableProperty should
take care of it.
> Provide option to not throw index write failure back to client
> --------------------------------------------------------------
>
> Key: PHOENIX-4028
> URL: https://issues.apache.org/jira/browse/PHOENIX-4028
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4028.patch, PHOENIX-4028_wip.patch
>
>
> Much like our DISABLE_INDEX_ON_WRITE_FAILURE and
> REBUILD_INDEX_ON_WRITE_FAILURE table properties, we need a
> THROW_INDEX_WRITE_FAILURE boolean option that can be used to prevent the
> index write from being thrown back to the client. In this case, the index
> failure policy would still be executed (i.e. disabling the index on a write
> failure), but any retry logic for the client would be avoided. The index
> would be eventually consistent based on the background partial index rebuild
> thread.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
