[ 
https://issues.apache.org/jira/browse/PHOENIX-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101193#comment-16101193
 ] 

Hudson commented on PHOENIX-3997:
---------------------------------

FAILURE: Integrated in Jenkins build Phoenix-master #1722 (See 
[https://builds.apache.org/job/Phoenix-master/1722/])
PHOENIX-3997 UngroupedAggregateRegionObserver.commitBatchWithHTable() 
(apurtell: rev a788111311f9b260c4eddbe7e9d2359a312b8d30)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java


> UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check the 
> memstore size and wait for flush. 
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3997
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3997
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Thomas D'Silva
>            Assignee: Geoffrey Jacoby
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-3997.patch, PHOENIX-3997-v2.patch, 
> PHOENIX-3997-v3.patch
>
>
> [~ankit.singhal] 
> In UngroupedAggregateRegionObserver.commitBatchWithHTable() do we need to 
> check the memstore size and wait for the flush. We are using a htable to 
> write the mutations.
> {code}
>  // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds 
> for the
>         // flush happen which decrease the memstore size and then writes 
> allowed on the region.
>         for (int i = 0; region.getMemstoreSize().get() > blockingMemstoreSize 
> && i < 30; i++) {
>             try {
>                 checkForRegionClosing();
>                 Thread.sleep(100);
>             } catch (InterruptedException e) {
>                 Thread.currentThread().interrupt();
>                 throw new IOException(e);
>             }
>         }
>         logger.debug("Committing batch of " + mutations.size() + " mutations 
> for " + table);
>         try {
>             table.batch(mutations);
>         } catch (InterruptedException e) {
>             throw new RuntimeException(e);
>         }
> {code}
> FYI [~jamestaylor] [~apurtell]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to