[ 
https://issues.apache.org/jira/browse/PHOENIX-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108390#comment-16108390
 ] 

James Taylor commented on PHOENIX-153:
--------------------------------------

Seems like review comments aren't appearing here in JIRA (maybe because your 
commit message doesn't include the JIRA number in the expected format), so I'll 
repeat it here:

Let's move the explain for the sampling into the first line, before we recurse 
down for the other steps. You can put it on the same line, after the "-WAY " 
like this:

    CLIENT PARALLEL 1-WAY 0.48-SAMPLED ...

Otherwise, users will interpret the sampling as happening after the 
scan/filtering which isn't the case.

> Implement TABLESAMPLE clause
> ----------------------------
>
>                 Key: PHOENIX-153
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-153
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: James Taylor
>            Assignee: Ethan Wang
>              Labels: enhancement
>         Attachments: Sampling_Accuracy_Performance.jpg
>
>
> Support the standard SQL TABLESAMPLE clause by implementing a filter that 
> uses a skip next hint based on the region boundaries of the table to only 
> return n rows per region.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to