[
https://issues.apache.org/jira/browse/PHOENIX-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114931#comment-16114931
]
Geoffrey Jacoby commented on PHOENIX-4066:
------------------------------------------
Test failures are two timeouts (QueryIT and QueryDatabaseMetaDataIT) and one
mini-cluster-failed-to-start (AlterMultiTenantTableWithViewsIT, which doesn't
seem to have anything to do with this change.)
> Unused variable in MutationState.send()
> ---------------------------------------
>
> Key: PHOENIX-4066
> URL: https://issues.apache.org/jira/browse/PHOENIX-4066
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.11.0
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Trivial
> Labels: beginner
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4066.patch
>
>
> In MutationState#send, we always allocate the following:
> List<TableRef> txTableRefs =
> Lists.newArrayListWithExpectedSize(mutations.size());
> and if a table's transactional, we populate it:
> txTableRefs.add(origTableRef);`
> but this is never referred to again in either logic or logging, and it's a
> local variable so we can't be using it elsewhere either. It should be removed
> or used (and if used, it should only be allocated in the transactional use
> case.)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)