[
https://issues.apache.org/jira/browse/PHOENIX-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149416#comment-16149416
]
Samarth Jain edited comment on PHOENIX-4110 at 8/31/17 6:41 PM:
----------------------------------------------------------------
Updated patch. I noticed that some tests like HashJoinIT create almost 100
tables. When shutting down the mini cluster for these many regions, I have seen
instances where mini cluster shutdown ran into issues. We can be a bit smarter
about it and shutdown and restart the mini cluster in @Before and @After
methods instead of waiting to shut them down in @AfterClass methods. Note that
for parameterized tests, the @AfterClass is invoked only after all the
parameterized runs are done. So an eager restart may be warranted in such
cases. Let's see if this helps.
was (Author: samarthjain):
Updated patch. I noticed that some tests like HashJoinIT create almost 100
tables. When shutting down the mini cluster for these many regions, I have seen
instances where mini cluster shutdown ran into issues. We can be a bit smarter
about it and shutdown and restart the mini cluster in @Before and @After
methods. Let's see if this helps.
> ParallelRunListener should monitor number of tables and not number of tests
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-4110
> URL: https://issues.apache.org/jira/browse/PHOENIX-4110
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-4110.patch,
> PHOENIX-4110_V2_4.x-HBase-0.98.patch, PHOENIX-4110_v3_4.x-HBase-0.98.patch,
> PHOENIX-4110_v3.patch, PHOENIX-4110_v4.patch, PHOENIX-4110_v5.patch,
> PHOENIX-4110_v6.patch
>
>
> ParallelRunListener today monitors the number of tests that have been run to
> determine when mini cluster should be shut down. This helps prevent our test
> JVM forks running in OOM. A better heuristic would be to instead check the
> number of tables that were created by tests. This way when a particular test
> class has created lots of tables, we can shut down the mini cluster sooner.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
