[ 
https://issues.apache.org/jira/browse/PHOENIX-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152422#comment-16152422
 ] 

Hadoop QA commented on PHOENIX-4156:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12885211/PHOENIX-4156_v2.patch
  against master branch at commit f03c43bdd2abb18f3a1edbc717340b52b529fb48.
  ATTACHMENT ID: 12885211

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        serverProps.put(QueryServices.INDEX_REBUILD_RPC_RETRIES_COUNTER, 
Long.toString(numRpcRetries));
+        
serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_OVERLAP_FORWARD_TIME_ATTRIB,
 Long.toString(forwardOverlapMs));
+        // disable running the index rebuild task because we want to control 
it's execution ourselves
+        serverProps.put(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB, 
Boolean.FALSE.toString());
+        
serverProps.put(QueryServices.INDEX_REBUILD_DISABLE_TIMESTAMP_THRESHOLD, 
Long.toString(disableTimestampThresholdMs));
+    private void checkStateAfterRebuild(Connection conn, String fullIndexName, 
PIndexState expectedIndexState) throws InterruptedException, SQLException {
+            rebuildIndexOnFailure = 
env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_ATTRIB,

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableSnapshotReadsMapReduceIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1366//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1366//console

This message is automatically generated.

> Fix flapping MutableIndexFailureIT
> ----------------------------------
>
>                 Key: PHOENIX-4156
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4156
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4156_v1.patch, PHOENIX-4156_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to