[
https://issues.apache.org/jira/browse/PHOENIX-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156119#comment-16156119
]
Hadoop QA commented on PHOENIX-4173:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12885657/PHOENIX-4173.patch
against master branch at commit ad52201e07670d342ef33c5e8bd2ee595fe559cc.
ATTACHMENT ID: 12885657
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("CREATE TABLE " + fullTableName
+ "(k VARCHAR PRIMARY KEY, v1 VARCHAR, v2 VARCHAR, v3 VARCHAR)
COLUMN_ENCODED_BYTES = 0, STORE_NULLS=true");
+ conn.createStatement().execute("CREATE INDEX " + indexName + " ON
" + fullTableName + " (v1, v2) INCLUDE (v3)");
+ conn.createStatement().execute("UPSERT INTO " + fullTableName + "
VALUES('a','a','0','x')");
+ try (HTableInterface metaTable =
conn.unwrap(PhoenixConnection.class).getQueryServices().getTable(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES))
{
+ // By using an INDEX_DISABLE_TIMESTAMP of 0, we prevent the
partial index rebuilder from triggering
+ conn.createStatement().execute("UPSERT INTO " + fullTableName
+ " VALUES('b','bb', '11','yy')");
+ conn.createStatement().execute("UPSERT INTO " + fullTableName
+ " VALUES('a','ccc','222','zzz')");
+ conn.createStatement().execute("UPSERT INTO " + fullTableName
+ " VALUES('a','dddd','3333','zzzz')");
+ IndexUtil.updateIndexState(fullIndexName, disableTime,
metaTable, PIndexState.DISABLE);
+ conn.createStatement().execute("UPSERT INTO " + fullTableName
+ " VALUES('a','eeeee','44444','zzzzz')");
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1382//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1382//console
This message is automatically generated.
> Ensure that the rebuild fails if an index that transitions back to disabled
> while rebuilding
> --------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4173
> URL: https://issues.apache.org/jira/browse/PHOENIX-4173
> Project: Phoenix
> Issue Type: Test
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4173.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)