[
https://issues.apache.org/jira/browse/PHOENIX-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156200#comment-16156200
]
Lars Hofhansl commented on PHOENIX-4165:
----------------------------------------
Actually MemoryManager and MemoryChunk have good javadoc already.
We also have MemoryManagerTest. I know I've been saying we need more test, but
this instance does not change failure scenarios, just that we do not wait for
memory.
After talking a bit with James... Here's a more radical patch that removes all
the wait/notify logic, all all related tests.
> Do not wait no new memory chunk can be allocated
> ------------------------------------------------
>
> Key: PHOENIX-4165
> URL: https://issues.apache.org/jira/browse/PHOENIX-4165
> Project: Phoenix
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Attachments: 4165.txt
>
>
> Currently the code waits for up to 10s by fault for memory to become
> "available".
> I think it's better to fail immediately and the let the client retry rather
> than waiting on an HBase handler thread.
> In a first iteration we can simply set the max wait time to 0 (or perhaps
> even -1) so that we do not attempt to wait but fail immediately. All using
> code should already deal with InsufficientMemoryExceptions, since they can
> already happen right now,
> In a second step I'd suggest to actually remove the waiting code and config
> option completely.
> [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
