[ 
https://issues.apache.org/jira/browse/PHOENIX-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156400#comment-16156400
 ] 

Hadoop QA commented on PHOENIX-4175:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12885716/PHOENIX-4175_1.patch
  against master branch at commit 28aebd6af3b635c98c8f1782295ea6c85167d659.
  ATTACHMENT ID: 12885716

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    private static void initTableValues(Connection conn, String tenantId, 
String tableName) throws Exception {
+                "    CONSTRAINT pk PRIMARY KEY (organization_id, key_prefix, 
custom_entity_data_id)) SPLIT ON ('" + tenantId + "00A','" + tenantId + 
"00B','" + tenantId + "00C')";
+        Connection conn = DriverManager.getConnection(getUrl(), 
PropertiesUtil.deepCopy(TEST_PROPERTIES));
+        String query = "SELECT 
CREATED_BY,CREATED_DATE,CURRENCY_ISO_CODE,DELETED,DIVISION,LAST_UPDATE,LAST_UPDATE_BY,NAME,OWNER,SYSTEM_MODSTAMP,VAL0,VAL1,VAL2,VAL3,VAL4,VAL5,VAL6,VAL7,VAL8,VAL9
 FROM " + tableName + " WHERE organization_id=?";
+        Connection conn = DriverManager.getConnection(getUrl(), 
PropertiesUtil.deepCopy(TEST_PROPERTIES));
+        String query = "SELECT KEY_PREFIX||CUSTOM_ENTITY_DATA_ID FROM " + 
tableName + " where '00A'||val0 LIKE '00A2%'";
+        Connection conn = DriverManager.getConnection(getUrl(), 
PropertiesUtil.deepCopy(TEST_PROPERTIES));
+                "    CONSTRAINT pk PRIMARY KEY (organization_id, key_prefix, 
custom_entity_data_id)) " + (saltTable ? "salt_buckets = 2"  : "");

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1394//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1394//console

This message is automatically generated.

> Convert tests using CURRENT_SCN to not use it when possible
> -----------------------------------------------------------
>
>                 Key: PHOENIX-4175
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4175
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-4175_1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to