[
https://issues.apache.org/jira/browse/PHOENIX-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156495#comment-16156495
]
James Taylor edited comment on PHOENIX-3953 at 9/7/17 5:41 AM:
---------------------------------------------------------------
Patch that moves check to postCompact hook. [~lhofhansl] - is it correct that
when CompactionRequest.isAllFiles() is true, that that means a major compaction
is happening (i.e. delete markers will be removed)?
Please review, [~lhofhansl] and/or [~vincentpoon], [~samarthjain]. The existing
test that tests that the index is disabled after compaction is
PartialIndexRebuilderIT.testCompactionDuringRebuild().
was (Author: jamestaylor):
Patch that moves check to postCompact hook. [~lhofhansl] - is it correct that
when CompactionRequest.isAllFiles() is true, that that means a major compaction
is happening (i.e. delete markers will be removed)?
Please review, [~lhofhansl] and/or [~vincentpoon]. The existing test that tests
that the index is disabled after compaction is
PartialIndexRebuilderIT.testCompactionDuringRebuild().
> Clear INDEX_DISABLED_TIMESTAMP and disable index on compaction
> --------------------------------------------------------------
>
> Key: PHOENIX-3953
> URL: https://issues.apache.org/jira/browse/PHOENIX-3953
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Labels: globalMutableSecondaryIndex
> Fix For: 4.12.0
>
> Attachments: PHOENIX-3953_addendum1.patch,
> PHOENIX-3953_addendum2.patch, PHOENIX-3953.patch, PHOENIX-3953_v2.patch
>
>
> To guard against a compaction occurring (which would potentially clear delete
> markers and puts that the partial index rebuild process counts on to properly
> catch up an index with the data table), we should clear the
> INDEX_DISABLED_TIMESTAMP and mark the index as disabled. This could be done
> in the post compaction coprocessor hook. At this point, a manual rebuild of
> the index would be required.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
