[
https://issues.apache.org/jira/browse/PHOENIX-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159746#comment-16159746
]
Hadoop QA commented on PHOENIX-4188:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886222/PHOENIX-4188.001.patch
against master branch at commit 2ad5d4b48c16743b3f3968a858f9da19c14070fa.
ATTACHMENT ID: 12886222
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 19 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ <!-- This column type defines what will generally happen to
VARCHAR fields unless they are explicitly defined or overridden elsewhere -->
+ This pattern is really useful when you want to write data to
multi-tenant view and the tenant id is
+ tightly bound to the scenario. In such cases you can't create
the view through the data model flow.
+ The value of the tableName attribute is name of the view that is
dynamically created based on the DDL
+ in the ddl attribute. Queries accessing the View will need to
manually make sure Pherf was run with the -l option at
+ ddl="CREATE VIEW IF NOT EXISTS PHERF.TEST_MT_VIEW (field1
VARCHAR) AS SELECT * FROM PHERF.TEST_MULTI_TENANT_TABLE"
+<ns3:dataModelResult
xmlns:ns2="org.apache.phoenix.pherf.configuration.DataModel"
xmlns:ns3="org.apache.phoenix.pherf.result" zookeeper="localhost:2181/hbase"
name="test_scenario">
+ <querySetResult concurrency="1-3" executionDurationInMs="5000"
executionType="SERIAL" numberOfExecutions="100">
+ <queryResults expectedAggregateRowCount="50" id="q1"
statement="select count(*) from PHERF.USER_DEFINED_TEST">
+ <runTimesInMs elapsedDurationInMs="37" resultRowCount="50"
startTime="2017-09-08T19:27:41.556-04:00"/>
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1414//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1414//console
This message is automatically generated.
> Disable DTD parsing on Pherf XML documents
> ------------------------------------------
>
> Key: PHOENIX-4188
> URL: https://issues.apache.org/jira/browse/PHOENIX-4188
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4188.001.patch
>
>
> A security scan dinged Phoenix for an external entities attack on the XML
> files that Pherf creates.
> We can easily work around it by disabling the inline doctype definition in
> the XML parser we use.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
