[ https://issues.apache.org/jira/browse/PHOENIX-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165175#comment-16165175 ]
ASF GitHub Bot commented on PHOENIX-4180: ----------------------------------------- GitHub user rhshriva opened a pull request: https://github.com/apache/phoenix/pull/271 PHOENIX-4180 - Modify tests to generate unique table names and not us… The following tests was changed. ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/rhshriva/phoenix master_IT_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/271.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #271 ---- commit 17c278a130ca2b0b3fe82abe4dda9cfe61c4fa08 Author: Rahul <rshrivast...@salesforce.com> Date: 2017-09-13T19:34:10Z PHOENIX-4180 - Modify tests to generate unique table names and not use CURRENT_SCN ---- > Modify tests to generate unique table names and not use CURRENT_SCN > ------------------------------------------------------------------- > > Key: PHOENIX-4180 > URL: https://issues.apache.org/jira/browse/PHOENIX-4180 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.12.0 > Reporter: Rahul Shrivastava > Assignee: Rahul Shrivastava > Priority: Minor > > Here is update provided by [~jamestaylor] > - switch from using hard coded table names to generated table names (using > the BaseTest.generateUniqueName() function). > - remove the setting of the CURRENT_SCN property name > - verify the tests still passes > Here's an example commit of the conversion of one of them: > https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commitdiff;h=814276d4b4b08be0681f1c402cfb3cc35f01fa0a;hp=b46cbd375e3d2ee9a11644825c13937572c027cd > Here's the list of tests that need to be converted: > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DistinctCountIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DropSchemaIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ExtendedQueryExecIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/FunkyNamesIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)